| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Kevin Grittner <kgrittn(at)ymail(dot)com>, "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A minor correction in comment in heaptuple.c |
| Date: | 2014-01-25 21:29:36 |
| Message-ID: | 20140125212936.GX7182@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-01-25 16:28:09 -0500, Bruce Momjian wrote:
> On Tue, Jun 18, 2013 at 11:04:25AM -0700, Kevin Grittner wrote:
> > D'Arcy J.M. Cain <darcy(at)druid(dot)net>
> >
> > > Although, the more I think about it, the more I think that the comment
> > > is both confusing and superfluous. The code itself is much clearer.
> >
> > Seriously, if there is any comment there at all, it should be a
> > succinct explanation for why we didn't do this (which passes `make
> > check-world`):
>
> Is everyone OK with me applying this patch from Kevin, attached?
No. I still think this is stupid. Not at all clearer and possibly breaks
stuff.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-01-25 21:33:16 | Re: A minor correction in comment in heaptuple.c |
| Previous Message | Bruce Momjian | 2014-01-25 21:28:09 | Re: A minor correction in comment in heaptuple.c |