| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Hale Boyes <kcboyes(at)gmail(dot)com>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Add DISCARD SEQUENCES command. |
| Date: | 2013-10-06 04:25:06 |
| Message-ID: | 20131006042506.GB6135@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier escribió:
> =# discard sequences ;
> DISCARD SEQUENCES
> =# select currval('foo');
> ERROR: 55000: currval of sequence "foo" is not yet defined in this session
> LOCATION: currval_oid, sequence.c:780
> =# select lastval();
> The connection to the server was lost. Attempting reset: Failed.
I wonder if it would be better to have this "seqtab" thing be a dlist,
and move the most recently used item to head position on nextval().
That way we don't have to maintain last_used_seq separately.
I also just noticed that the DISCARD SEQUENCE patch made a "NOTE:"
comment in init_sequence be outdated.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2013-10-06 07:51:53 | Re: [COMMITTERS] pgsql: Add DISCARD SEQUENCES command. |
| Previous Message | Alvaro Herrera | 2013-10-06 02:54:17 | pgsql: Fix various bugs in postmaster SIGKILL processing |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2013-10-06 07:40:40 | Re: pgbench progress report improvements - split 3 v2 - A |
| Previous Message | Alvaro Herrera | 2013-10-06 02:54:38 | Re: 9.4 HEAD: select() failed in postmaster |