missing SSI check in heapgettup_pagemode() ?

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Kevin Grittner <kgrittn(at)ymail(dot)com>, Dan Ports <drkp(at)csail(dot)mit(dot)edu>
Subject: missing SSI check in heapgettup_pagemode() ?
Date: 2013-09-05 17:30:34
Message-ID: 20130905173034.GD6067@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I was scrolling heapgettup() and heapgettup_pagemode() in parallel, and
noticed that the former calls CheckForSerializableConflictOut() for
tuples read, and the latter doesn't. Is there a reason for this
discrepancy? If so, I think it warrants a comment about the missing
check.

Thanks,

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2013-09-05 17:41:25 Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric?
Previous Message Heikki Linnakangas 2013-09-05 17:29:35 Re: Analysis on backend-private memory usage (and a patch)