Re: Should we remove "not fast" promotion at all?

On 2013-08-07 22:26:53 +0900, Fujii Masao wrote:
> On Tue, Aug 6, 2013 at 1:07 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> >> On Tue, Aug 6, 2013 at 11:40 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> >>> FWIW I'd rather keep plain promotion for a release or two. TBH, I have a
> >>> bit of trust issues regarding the new method, and I'd like to be able to
> >>> test potential issues against a stock postgres by doing a normal instead
> >>> of a fast promotion.
> >
> >> So we should add new option specifying the promotion mode, into pg_ctl?
> >> Currently pg_ctl cannot trigger the normal promotion.
> >
> > It would be silly to add such an option if we want to remove the old mode
> > in a release or two.
>
> Without such an option, a user cannot easily trigger the "normal" promotion
> when we find some problems in fast promotion. In this case, a user needs to
> create the "promote" file and send the SIGUSR1 signal to postmaster by hand.
> Or needs to execute pg_ctl promote by using old version (e.g., 9.2) of pg_ctl.
> Seems confusing.

Seems fine for debugging to me.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services