Re: [BUGS] BUG #8128: pg_dump (>= 9.1) failed while dumping a scheme named "old" from PostgreSQL 8.4

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Adrian(dot)Vondendriesch(at)credativ(dot)de, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #8128: pg_dump (>= 9.1) failed while dumping a scheme named "old" from PostgreSQL 8.4
Date: 2013-05-01 14:26:53
Message-ID: 20130501142653.GB16330@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Apr 30, 2013 at 07:53:27PM -0400, Tom Lane wrote:
> Adrian(dot)Vondendriesch(at)credativ(dot)de writes:
> > [ recent pg_dump fails against an 8.4 server if "old" is used as a
> > name ]
>
> Yeah. The reason for this is that "old" was considered a reserved
> word in 8.4 and before, but since 9.0 it is not reserved (indeed it
> isn't a keyword at all anymore), so 9.0 and later pg_dump don't
> think they need to quote it in commands.

According to SQL:2003 and SQL:2008 (and the draft standard, if that
matters) in section 5.2 of Foundation, both NEW and OLD are reserved
words, so we're going to need to re-reserve them to comply.

Sadly, this will cause problems for people who have tables with those
names, but we've introduced incompatibilities (in 8.3, e.g.) that hit
a much bigger part of our user base much harder than this. When we do
re-reserve, we'll need to come up with a migration path.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2013-05-01 14:37:40 Re: Re: [BUGS] BUG #8128: pg_dump (>= 9.1) failed while dumping a scheme named "old" from PostgreSQL 8.4
Previous Message stefan 2013-05-01 12:48:07 BUG #8130: Hashjoin still gives issues

Browse pgsql-hackers by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2013-05-01 14:37:40 Re: Re: [BUGS] BUG #8128: pg_dump (>= 9.1) failed while dumping a scheme named "old" from PostgreSQL 8.4
Previous Message Tom Lane 2013-05-01 14:06:55 Re: In progress INSERT wrecks plans on table