Re: pgsql: Add support for piping COPY to/from an external program.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add support for piping COPY to/from an external program.
Date: 2013-02-28 16:32:24
Message-ID: 20130228163224.GL9507@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Heikki Linnakangas wrote:

> This creates a new function in pgport, wait_result_to_str(), which can
> be used to convert the exit status of a process, as returned by wait(3),
> to a human-readable string.

You have this:

+#ifndef FRONTEND
+ result = pstrdup(str);
+#else
+ result = strdup(str);
+#endif

This kind of thing is no longer necessary. In frontend, libpgcommon
provides a pstrdup() implementation which is strdup() plus error check,
so you can reduce the above to simply

result = pstrdup(str);

and it should work everywhere.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2013-02-28 16:54:38 Re: Materialized views WIP patch
Previous Message Heikki Linnakangas 2013-02-28 16:08:50 Re: Materialized views WIP patch