| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_xlogdump compiler warning |
| Date: | 2013-02-27 10:01:06 |
| Message-ID: | 20130227100106.GA7733@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-02-26 15:52:01 -0500, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2013-02-25 18:15:48 -0500, Peter Eisentraut wrote:
> >> compat.c: In function ‘timestamptz_to_str’:
> >> compat.c:56:9: error: passing argument 1 of ‘localtime’ from incompatible pointer type [-Werror]
> >> In file included from compat.c:21:0:
> >> /usr/include/time.h:237:19: note: expected ‘const time_t *’ but argument is of type ‘pg_time_t *’
>
> > 32bit I guess?
>
> Yeah, I see the same on a 32-bit machine.
>
> > A simple cast should do for now. Patch attached.
>
> Pushed along with some other, more cosmetic cleanups.
Thanks. The statics's et al were stupid, my fault.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ivan Lezhnjov IV | 2013-02-27 11:11:40 | Re: backup.sgml patch that adds information on custom format backups |
| Previous Message | Thom Brown | 2013-02-27 09:52:38 | Re: pgsql: Fix pg_dumpall with database names containing = |