| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_xlogdump |
| Date: | 2013-02-24 13:59:04 |
| Message-ID: | 20130224135904.GB3242@alap2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-02-23 14:54:51 -0800, Jeff Janes wrote:
> If I run "make clean", or "make maintainer-clean", this deletes the file
> contrib/pg_xlogdump/rmgrdesc.c. And then config/make doesn't know how to
> get it back again.
>
> I don't know if the Makefile needs to be taught not to delete it, or taught
> how to recreate it once deleted.
It shouldn't be deleted, I think neither Alvaro nor me did notice this
because it only matters in non-vpath builds...
Patch attached.
I independently wonder whether we should remove the PGXS stub from
xlogdump, given it relies on a full sourcetree available?
Andres
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| xlogdump-dont-remove-rmgrdesc.c.patch | text/x-patch | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2013-02-24 14:03:44 | Re: Strange Windows problem, lock_timeout test request |
| Previous Message | Andrew Dunstan | 2013-02-24 13:58:58 | Re: json generation enhancements |