Re: could not create directory "...": File exists

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> I committed this with a couple of changes:

Great, thanks!

> * I used GetLatestSnapshot rather than GetTransactionSnapshot. Since
> we don't allow these operations inside transaction blocks, there
> shouldn't be much difference, but in principle GetTransactionSnapshot
> is the wrong thing; in a serializable transaction it could be quite old.

Makes sense.

> * After reviewing the other uses of SnapshotNow in dbcommands.c, I
> decided we'd better make the same type of change in remove_dbtablespaces
> and check_db_file_conflict, because those are likewise doing filesystem
> operations on the strength of what they find in pg_tablespace.

Thanks for that. I had noticed the other places where we were using
SnapshotNow, but I hadn't run down if they needed to be changed or not.

> I also ended up deciding to back-patch to 8.3 as well.

Excellent, thanks again.

Stephen