Re: [HACKERS] \copy (query) delimiter syntax error

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Michael Fuhr <mike(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] \copy (query) delimiter syntax error
Date: 2007-02-04 17:38:40
Message-ID: 20127.1170610720@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> oh, good point. OK, I have cut this quick patch that will continue to
> accept the legacy syntax in psql in non-inline-query cases, but will
> make psql unreservedly emit new style syntax for COPY to the backend.
> Does that seem reasonable, or is it too much of a change for the stable
> branch?

We've never promised that psql's backslash commands would work at all
with older backends, so I think removing compatibility with pre-7.3
backends at this point isn't a problem. OTOH, going out of your way
to remove compatibility seems a bit pointless, so I'd vote against the
"have_query" parts of this patch. Just change the output format.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Wieck 2007-02-04 18:36:03 Re: Proposal: Commit timestamp
Previous Message Martijn van Oosterhout 2007-02-04 17:36:16 Re: VC2005 build and pthreads

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-02-04 18:23:29 Re: [pgsql-patches] Recalculating OldestXmin in a long-running vacuum
Previous Message Tom Lane 2007-02-04 17:32:32 Re: [BUGS] BUG #2221: Bad delimiters allowed in COPY ...