From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Devrim GÜNDÜZ <devrim(at)gunduz(dot)org> |
Cc: | PostgreSQL Hackers ML <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_upgrade does not completely honor --new-port |
Date: | 2012-09-27 02:06:50 |
Message-ID: | 20120927020650.GA29352@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Sep 25, 2012 at 05:36:54PM +0300, Devrim Gunduz wrote:
>
> Hi,
>
> I just performed a test upgrade from 9.1 to 9.2, and used --new-port
> variable. However, the analyze_new_cluster.sh does not include the new
> port, thus when I run it, it fails. Any chance to add the port number to
> the script?
Well, the reason people normally use the port number is to do a live
check, but obviously when the script is created it isn't doing a check.
I am worried that if I do embed the port number in there, then if they
change the port after the upgrade, they now can't use the script. I
assume users would have PGPORT set before running the script, no?
> Also, is it worth to add the value specified in --new-bindir as a prefix
> to vacuumdb command in the same script?
Wow, I never thought of adding a path to those scripts, but it certainly
makes sense. I have created the attached patch which does this.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
Attachment | Content-Type | Size |
---|---|---|
path.diff | text/x-diff | 2.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2012-09-27 03:41:36 | Re: [WIP] Performance Improvement by reducing WAL for Update Operation |
Previous Message | Andrew Dunstan | 2012-09-27 02:00:52 | Re: Modest proposal: run check_keywords.pl on every build |