Re: somewhat wrong archive_command example

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, pgsql-docs(at)postgresql(dot)org
Subject: Re: somewhat wrong archive_command example
Date: 2012-08-25 23:40:26
Message-ID: 20120825234026.GG10814@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Sat, Aug 25, 2012 at 07:07:55PM -0400, Bruce Momjian wrote:
> > >I have made all the suggestions posted and would like to add the
> > >attached script to our documentation as a simple example.
> >
> > Btw., is anyone else concerned about using plain cp for this? If
> > the cp fails half-way, it leaves a partial file around, but
> > subsequent file existence checks will find the file OK and skip it.
> >
> > I have occasionally used some combination of mktemp + cp + mv, which
> > seems to work around this problem.
>
> I am unclear why the script returns success if the file already exists
> --- seems if the file exists, we should throw an error, like we have
> always done with cp -i < /dev/null.
>
> Updated version attached.
>
> Another option in this case would be to re-issue the copy.

Sorry, proper attached file this time.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachment Content-Type Size
local_backup_script.sh application/x-sh 555 bytes

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Bruce Momjian 2012-08-26 20:35:19 Re: CREATE TABLE LIKE, regarding constraints
Previous Message Bruce Momjian 2012-08-25 23:07:55 Re: somewhat wrong archive_command example