Re: pgsql: Modify pg_dump to use error-free memory allocation macros. This

\Andrew Dunstan wrote:
>
>
> On 11/26/2011 02:13 AM, Tom Lane wrote:
> > Bruce Momjian<bruce(at)momjian(dot)us> writes:
> >> Modify pg_dump to use error-free memory allocation macros. This avoids
> >> ignoring errors and call-site error checking.
> > This appears to have broken the MSVC build. More generally, I'd like to
> > object to arbitrarily moving a bunch of longstanding code from one file
> > to another. What that is mainly going to accomplish is creating a big
> > headache whenever we have to back-patch fixes that touch that code
> > ... and what exactly did it buy in return?
> >
> >
>
>
> Was there any discussion of this change? It seems much too big for
> something to be done without discussion, but I don't recall seeing
> anything. (And it's probably seriously broken two patches I have in the
> commitfest).

The patch was posted Novembrer 14 and received no replies:

http://archives.postgresql.org/pgsql-hackers/2011-11/msg00860.php

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +