Re: [GENERAL] pg_upgrade problem

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, depesz(at)depesz(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] pg_upgrade problem
Date: 2011-09-07 18:43:19
Message-ID: 201109071843.p87IhJY27277@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Bruce Momjian wrote:
> Tom Lane wrote:
> > hubert depesz lubaczewski <depesz(at)depesz(dot)com> writes:
> > > Worked a bit to get the ltree problem down to smallest possible, repeatable, situation.
> >
> > I looked at this again and verified that indeed, commit
> > 8eee65c996048848c20f6637c1d12b319a4ce244 introduced an incompatible
> > change into the on-disk format of ltree columns: it widened
> > ltree_level.len, which is one component of an ltree on disk.
> > So the crash is hardly surprising. I think that the only thing
> > pg_upgrade could do about it is refuse to upgrade when ltree columns
> > are present in an 8.3 database. I'm not sure though how you'd identify
> > contrib/ltree versus some random user-defined type named ltree.
>
> It is actually easy to do using the attached patch. I check for the
> functions that support the data type and check of they are from an
> 'ltree' shared object. I don't check actual user table type names in
> this case.

Attached patch applied to 9.0, 9.1, and HEAD. Doc changes included.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachment Content-Type Size
/rtmp/pg_upgrade.9.0 text/x-diff 4.5 KB
/rtmp/pg_upgrade text/x-diff 4.5 KB

In response to

Browse pgsql-general by date

  From Date Subject
Next Message hyelluas 2011-09-07 18:49:35 Re: Advice on HA option
Previous Message Mike Orr 2011-09-07 18:38:26 Re: Complex query question

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2011-09-07 19:07:55 Re: custom variables and PGC_SUSET issue
Previous Message Tom Lane 2011-09-07 18:37:27 Re: [PATCH] Don't truncate integer part in to_char for 'FM99.'