Re: Couple document fixes

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Couple document fixes
Date: 2011-09-05 23:33:09
Message-ID: 201109052333.p85NX9F26135@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

David Fetter wrote:
> > > > I am unsure on that one. We have many 'char' mentions in
> > > > catalog.sgml, and I don't see any of them shown as '"char"'.
> > > > (Wow, we should have just called this type char1, but I think
> > > > that name came from Berkeley!) The big problem is that the
> > > > pg_type name is really "char" _without_ quotes.
> > >
> > > One idea is to rename the type to something else. We could keep
> > > "char" as an alias for backwards compatibility, but use the new
> > > name in system catalogs, and document it as the main name of the
> > > type.
> > >
> > > Discussed the idea a bit on IM with Bruce, but couldn't find any
> > > really good alternative. Idea floated so far:
> > >
> > > * byte (seems pretty decent to me) * octet (though maybe people
> > > would expect it'd output as a number) * char1 (looks ugly, but
> > > then we have int4 and so on) * achar (this one is just plain
> > > weird)
> > >
> > > None seems great. Thoughts?
> >
> > Any new ideas on how to document our "char" data type?
>
> What say we document it as deprecated and remove the silly thing over
> the next three releases or so? It's deep in the realm of
> micro-optimization, and of a kind we well and truly don't need any
> more, assuming we ever did.
>
> Alternate proposals would involve a more aggressive deprecation and
> removal schedule. ;)

Uh, pg_class uses it:

relpersistence | "char" | not null
relkind | "char" | not null

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message David Fetter 2011-09-06 00:05:10 Re: Couple document fixes
Previous Message David Fetter 2011-09-05 23:29:16 Re: Couple document fixes

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2011-09-05 23:52:52 Re: PATCH: regular logging of checkpoint progress
Previous Message Bruce Momjian 2011-09-05 23:32:27 Re: Rectifying wrong Date outputs