Re: pgindent weirdness

Robert Haas wrote:
> pgindent seems to have muffed it when it comes to BulkInsertStateData:
>
> diff --git a/src/backend/access/heap/hio.c b/src/backend/access/heap/hio.c
> index 2849992..72a69e5 100644
> --- a/src/backend/access/heap/hio.c
> +++ b/src/backend/access/heap/hio.c
> @@ -150,7 +150,7 @@ ReadBufferBI(Relation relation, BlockNumber targetBlock,
> Buffer
> RelationGetBufferForTuple(Relation relation, Size len,
> Buffer otherBuffer,
> int options,
> - struct
> BulkInsertStateData *bistate)
> + struct
> BulkInsertStateData * bistate)
> {
> bool use_fsm = !(options & HEAP_INSERT_SKIP_FSM);
> Buffer buffer = InvalidBuffer;
>
> Not sure what happened here exactly...

BulkInsertStateData is not listed in the typedef list supplied by
Andrew; see src/tools/pgindent/typedefs.list. CC'ing him. This might
be because the typdef is listed in two files:

/*
* state for bulk inserts --- private to heapam.c and hio.c
*
* If current_buf isn't InvalidBuffer, then we are holding an extra pin
* on that buffer.
*
* "typedef struct BulkInsertStateData *BulkInsertState" is in heapam.h
*/

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +