| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix for pg_upgrade discriptor leaks |
| Date: | 2011-03-09 02:59:26 |
| Message-ID: | 201103090259.p292xQ512467@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I have applied the attached patch to fix pg_upgrade file descriptor
> > leaks in error paths.
>
> It seems rather pointless to spend code closing descriptors immediately
> before a fatal exit.
Well, it is not before a fatal but rather before it returns -1, which
might fatal or might not. I also had code in to close file descriptors
that was a little too tricky about using a single variable to indicate
two things so I cleaned it up. I got a private email report about these
so obviously they were confusing.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jaime Casanova | 2011-03-09 05:14:01 | Re: Sync Rep v19 |
| Previous Message | Tom Lane | 2011-03-09 02:57:50 | Re: Fix for pg_upgrade discriptor leaks |