Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Elliot Chance <elliotchance(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>)
Date: 2011-01-13 17:32:47
Message-ID: 201101131732.p0DHWl218905@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Excerpts from Tom Lane's message of lun dic 27 13:54:56 -0300 2010:
> >> [ lightbulb ] ... although we could improve that quite a bit if we
> >> processed each .h file separately instead of insisting on smashing
> >> everything into one compilation. Let me go try that.
>
> > FWIW I have this patch lingering about that I wrote months ago, to check
> > for header problems (not C++ stuff, just things like forgetting to
> > include some necessary header in some other header). Since it needs a
> > lot of polish (needs to ignore certain headers, and avoid leave
> > lingering files around), I didn't commit it; and I haven't updated it to
> > the new Make recursive stuff, either.
>
> src/tools/pginclude/ already contains several scripts for this sort of
> thing. Bruce runs them by hand occasionally, although I just found out
> that he's evidently not run the does-each-header-compile-standalone
> test in awhile. It would probably pay to automate these.

It is true I have not run those tests in a while.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Allen Chen 2011-01-13 17:34:45 Inconsistent time interval formatting
Previous Message Tom Lane 2011-01-13 17:20:20 Re: Record with a field consisting of table rows

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-01-13 17:43:35 Re: system views for walsender activity
Previous Message David Fetter 2011-01-13 17:12:35 Re: kill -KILL: What happens?