Re: pg_stat_user_functions' notion of user

From: David Fetter <david(at)fetter(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_stat_user_functions' notion of user
Date: 2010-08-08 15:40:13
Message-ID: 20100808154013.GA27785@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Aug 08, 2010 at 03:25:06PM +0300, Peter Eisentraut wrote:
> On tor, 2010-08-05 at 07:13 -0700, David Fetter wrote:
> > On Thu, Aug 05, 2010 at 04:58:32PM +0300, Peter Eisentraut wrote:
> > > pg_stat_user_functions has an inconsistent notion of what "user"
> > > is. Whereas the other pg_stat_user_* views filter out non-user
> > > objects by schema, pg_stat_user_functions checks for language
> > > "internal", which does not successfully exclude builtin
> > > functions of language SQL. Is there a reason for this
> > > inconsistency?
> >
> > If I had to hazard a guess, it would be that the functionality was
> > written over time by different people, not all of whom were using
> > the same criteria for coherence.
>
> Would anyone object to changing it to make it more consistent with
> other others? And since we're jollily making catalog changes in 9.0
> still, could this also be backpatched?

+1 for both.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-08-08 15:41:15 Re: scheduling
Previous Message Mike Fowler 2010-08-08 15:36:25 Re: Initial review of xslt with no limits patch