From: | David Fetter <david(at)fetter(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alex Hunsaker <badalex(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] Drop one-argument string_agg? (was Re: string_agg delimiter having no effect with order by) |
Date: | 2010-08-04 22:49:43 |
Message-ID: | 20100804224943.GA11611@fetter.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Wed, Aug 04, 2010 at 06:19:49PM -0400, Tom Lane wrote:
> I wrote:
> > Hm? I don't think that an initdb here would have any impact on whether
> > we can call the next drop RC1 or not. We're talking about removing a
> > single built-in entry in pg_proc --- it's one of the safest changes we
> > could possibly make.
>
> Well, I forgot that an aggregate involves more than one catalog row ;-).
> So it's a bit bigger patch than that, but still pretty small and safe.
> See attached.
>
> What we are doing here, IMO, is not just changing string_agg() but
> instituting a project policy that we are not going to offer built-in
> aggregates with the same names and different numbers of arguments ---
> otherwise the problem will come right back. Therefore, the attached
> patch adds an opr_sanity regression test that will complain if anyone
> tries to add such. Of course, this isn't preventing users from creating
> such aggregates, but it's on their own heads to not get confused if they
> do.
>
> This policy also implies that we are never going to allow default
> arguments for aggregates, or at least never have any built-in ones
> that use such a feature.
>
> By my count the following people had offered an opinion on making
> this change:
> for: tgl, josh, badalex, mmoncure
> against: rhaas, thom
> Anybody else want to vote, or change their vote after seeing the patch?
+1 for removing the single-argument version.
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
From | Date | Subject | |
---|---|---|---|
Next Message | Alex Hunsaker | 2010-08-04 22:57:25 | Re: [HACKERS] Drop one-argument string_agg? (was Re: string_agg delimiter having no effect with order by) |
Previous Message | Tom Lane | 2010-08-04 22:41:39 | Re: [HACKERS] Drop one-argument string_agg? (was Re: string_agg delimiter having no effect with order by) |
From | Date | Subject | |
---|---|---|---|
Next Message | Alex Hunsaker | 2010-08-04 22:57:25 | Re: [HACKERS] Drop one-argument string_agg? (was Re: string_agg delimiter having no effect with order by) |
Previous Message | Merlin Moncure | 2010-08-04 22:49:16 | Re: Using Small Size SSDs to improve performance? |