Re: is_absolute_path incorrect on Windows

From: Giles Lean <giles(dot)lean(at)pobox(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Greg Stark <gsstark(at)mit(dot)edu>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: is_absolute_path incorrect on Windows
Date: 2010-06-01 19:20:18
Message-ID: 20100601192018.9849.qmail@sapphire.netherstone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Yeah. If we were to go with Greg's suggestion of inventing a separate
> is_relative_to_cwd test function, I'd expect that to insist on no ".."
> while it was at it.

So it's now two problems, and I think this is my final comment:

1. is_relative_to_cwd() I continue to think is a bad name for something
concerned about ".." (plus on Windows not having a drive letter other
than the current one); the "normal" meaning of "relative path" is
merely "not absolute"

2. if this proposed new function is to replace some uses of
is_absolute_path() then I'm afraid I'd not picked up on that (as
Bruce did) and have no opinion on whether it's a good idea or not,
and am not qualified to be the one doing the code investigation (not
enough knowledge of the code, it's beta time, and I'm frantically
short of time just now as well, sorry)

Giles

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-06-01 20:04:02 Re: is_absolute_path incorrect on Windows
Previous Message Kevin Grittner 2010-06-01 19:17:36 CommitFest FAQ (was: dividing money by money)