| From: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Open Item: invalid declspec for PG_MODULE_MAGIC |
| Date: | 2010-05-26 02:23:26 |
| Message-ID: | 20100526112326.B280.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This open item is for replacing PGDLLIMPORT markers for PG_MODULE_MAGIC
and PG_FUNCTION_INFO_V1 to __declspec(dllexport) because they are always
expored by user modules rather than by the core codes.
http://archives.postgresql.org/message-id/20100329184705.A60E.52131E4D@oss.ntt.co.jp
The fix is simple, so I think we can include it to 9.0.
Arguable issues for the patch are:
* Are there better name than PGMODULEEXPORT? I like PGDLLEXPORT
because it is similar to PGDLLIMPORT, but it might be too similar.
* Should we backport the fix to previous releases?
I'd like to backport it because it should not break any existing
third party modules because they cannot be even built on Windows.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-05-26 02:29:07 | libpq should not be using SSL_CTX_set_client_cert_cb |
| Previous Message | Stephen Frost | 2010-05-26 02:16:43 | Re: ExecutorCheckPerms() hook |