Re: predefined macros for various BSD-based systems?

Tom Lane wrote:
> I'm not even too sure what "bsdi" is, but I'm suspicious of that branch
> too. A search of our code finds
>
> contrib/pg_upgrade/file.c: 248: #elif defined(freebsd) || defined(bsdi) || defined(__darwin__) || defined(openbsd)
> src/backend/utils/misc/ps_status.c: 67: #elif (defined(BSD) || defined(__bsdi__) || defined(__hurd__)) && !defined(__darwin__)
> src/include/port.h: 355: #if defined(bsdi) || defined(netbsd)
> src/port/fseeko.c: 20: #if defined(__bsdi__) || defined(__NetBSD__)
> src/port/fseeko.c: 24: #ifdef bsdi
> src/port/fseeko.c: 47: #ifdef bsdi
> src/port/fseeko.c: 55: #ifdef bsdi
> src/port/fseeko.c: 66: #ifdef bsdi
> src/port/fseeko.c: 76: #ifdef bsdi
> src/port/fseeko.c: 87: #ifdef bsdi
>
> which leaves one with not a lot of warm fuzzies that we know how to
> spell the symbol for either bsdi or netbsd. (Oh, and shouldn't
> this pg_upgrade check be looking for netbsd too?)

BSDi defines "bsdi" and "__bsdi__", but our code was clearly
inconsistent. I have changed all references to __bsdi__.

FYI, src/tools/ccsym will show you your predefined symbols.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com