| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib |
| Date: | 2010-05-12 21:42:47 |
| Message-ID: | 201005122142.o4CLglZ01418@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > All other binaries had such a designation, and all /contrib binaries
> > were missing them. I assume I was doing cleanup. You want the icon
> > removed from the backend makefile?
>
> Yes. I'm prepared to believe that not having the icons set on the
> contrib executables was an oversight. I'm much less prepared to assume
> that not marking the postgres executable was an oversight. Again,
> unless you *know* that this change is needed and appropriate, now is
> not the time to be making it, and especially not without discussion.
OK, done with attached patch, and I added a comment about why it is not
labeled.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| /rtmp/diff | text/x-diff | 782 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-05-12 21:46:19 | Re: pgsql: Hook pg_upgrade into the contrib makefile structure so it gets |
| Previous Message | Bruce Momjian | 2010-05-12 21:42:21 | pgsql: Remove Makefile PGFILEDESC tag that the postmaster is an |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-05-12 21:44:32 | Re: primary/secondary/master/slave/standby |
| Previous Message | Joshua D. Drake | 2010-05-12 21:40:44 | Re: max_standby_delay considered harmful |