pgsql: Clear error_context_stack and debug_query_string at the beginning

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Clear error_context_stack and debug_query_string at the beginning
Date: 2010-03-20 00:58:38
Message-ID: 20100320005838.89E617541D0@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Clear error_context_stack and debug_query_string at the beginning of proc_exit,
so that we won't try to attach any context printouts to messages that get
emitted while exiting. Per report from Dennis Koegel, the context functions
won't necessarily work after we've started shutting down the backend, and it
seems possible that debug_query_string could be pointing at freed storage
as well. The context information doesn't seem particularly relevant to
such messages anyway, so there's little lost by suppressing it.

Back-patch to all supported branches. I can only demonstrate a crash with
log_disconnections messages back to 8.1, but the risk seems real in 8.0 and
before anyway.

Tags:
----
REL8_0_STABLE

Modified Files:
--------------
pgsql/src/backend/storage/ipc:
ipc.c (r1.90 -> r1.90.4.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/ipc/ipc.c?r1=1.90&r2=1.90.4.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-03-20 00:58:46 pgsql: Clear error_context_stack and debug_query_string at the beginning
Previous Message Tom Lane 2010-03-20 00:58:32 pgsql: Clear error_context_stack and debug_query_string at the beginning