Re: pq_setkeepalives* functions

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pq_setkeepalives* functions
Date: 2010-03-13 17:02:06
Message-ID: 201003131702.o2DH26u02537@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> This makes the function *not* like the other two, rather than
> >> improving consistency.
>
> > Well, it makes it like some of the existing functions, but not like
> > others. This applied patch fixes them all.
>
> This is making things worse, not better. You have just changed the
> behavior, and not in a good way. Formerly these were no-ops on
> a unix socket connection, and now they can throw errors.

Is this the proper way to fix the issue? Patch attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do

Attachment Content-Type Size
/pgpatches/keepalive text/x-diff 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-03-13 17:10:47 Re: pq_setkeepalives* functions
Previous Message Pavel Stehule 2010-03-13 17:00:08 Re: Dyamic updates of NEW with pl/pgsql