Re: Re: [BUGS] BUG #5021: ts_parse doesn't recognize email addresses with underscores

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, "Dan O'Hara" <danarasoftware(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
Subject: Re: Re: [BUGS] BUG #5021: ts_parse doesn't recognize email addresses with underscores
Date: 2010-03-13 03:10:59
Message-ID: 201003130311.o2D3B0R04705@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > OK, I can add '+' using Teodor's patch as a guide, and document which
> > characters we support, and that we don't support all of them. What
> > about the binary upgrade issue? I am now worried that maybe we should
> > back out the patch and just document our restrictions.
>
> The tsearch stuff is supposedly designed to be flexible about that.
> It's not really any different from changing your tsearch configuration
> midstream. You might not get matches that you would have liked to get,
> but there's not any internal inconsistency.

Glad you are not worried. ;-)

What concerns me is if someone created a tsvector index or stored
tsvector output in a table using the old rules, a new query might not
match the binary-upgraded tsvector stored values.

You are right that internally it is fine.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2010-03-13 05:12:54 Re: BUG #5374: NULLed SERIAL improperly dumped
Previous Message Bruce Momjian 2010-03-13 03:08:30 Re: Re: [BUGS] BUG #5021: ts_parse doesn't recognize email addresses with underscores

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-03-13 03:28:38 Getting to beta1
Previous Message Bruce Momjian 2010-03-13 03:08:30 Re: Re: [BUGS] BUG #5021: ts_parse doesn't recognize email addresses with underscores