| From: | tgl(at)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Force READY portals into FAILED state when a transaction or |
| Date: | 2010-02-18 03:06:46 |
| Message-ID: | 20100218030646.500A37541C5@cvs.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
Force READY portals into FAILED state when a transaction or subtransaction
is aborted, if they were created within the failed xact. This prevents
ExecutorEnd from being run on them, which is a good idea because they may
contain references to tables or other objects that no longer exist.
In particular this is hazardous when auto_explain is active, but it's
really rather surprising that nobody has seen an issue with this before.
I'm back-patching this to 8.4, since that's the first version that contains
auto_explain or an ExecutorEnd hook, but I wonder whether we shouldn't
back-patch further.
Modified Files:
--------------
pgsql/src/backend/utils/mmgr:
portalmem.c (r1.116 -> r1.117)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mmgr/portalmem.c?r1=1.116&r2=1.117)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-02-18 03:06:54 | pgsql: Force READY portals into FAILED state when a transaction or |
| Previous Message | Tom Lane | 2010-02-18 01:29:10 | pgsql: Fix up pg_dump's treatment of large object ownership and ACLs. |