Skip site navigation (1) Skip section navigation (2)

Small Bug in pgstat display during recovery conflict resolution

From: Andres Freund <andres(at)anarazel(dot)de>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Small Bug in pgstat display during recovery conflict resolution
Date: 2010-02-07 20:47:39
Message-ID: 201002072147.41688.andres@anarazel.de (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi Simon, Hi all,


if (!logged && (wait_s > 0 || wait_us > 500000))
{
        const char *oldactivitymsg;
        int                     len;

        oldactivitymsg = get_ps_display(&len);
        snprintf(waitactivitymsg, sizeof(waitactivitymsg),
                         "waiting for max_standby_delay (%u s)",
                         MaxStandbyDelay);
        set_ps_display(waitactivitymsg, false);
        if (len > 100)
                len = 100;
        memcpy(waitactivitymsg, oldactivitymsg, len);

        pgstat_report_waiting(true);

        logged = true;
}
..
if (logged)
{
        set_ps_display(waitactivitymsg, false);
        pgstat_report_waiting(false);
}

That doesnt work because get_ps_display returns the internal buffer. This 
leads to the situation that after conflict resolution the 
"waiting for max_standby_delay ..."
message is displayed until the next segment starts where its replaced
again by the 
"... recovering ..." line.

Additionally the old code may print unintialized memory if get_ps_display
 returns a string without a \0 terminator.

The attached patch fixes that.

Andres

Attachment: 0001-The-stat-reporting-in-ResolveRecoveryConflictWithVir.patch
Description: text/x-patch (2.4 KB)

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-02-07 20:48:13
Subject: pgsql: Create a "relation mapping" infrastructure to support changing
Previous:From: Josh BerkusDate: 2010-02-07 20:37:56
Subject: Re: damage control mode

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group