pgsql: Disallow comments on columns of relation types other than tables,

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Disallow comments on columns of relation types other than tables,
Date: 2009-12-22 23:54:17
Message-ID: 20091222235417.D64FE753FB7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Disallow comments on columns of relation types other than tables, views,
and composite types, which are the only relkinds for which pg_dump support
exists for dumping column comments. There is no obvious usefulness for
comments on columns of sequences or toast tables; and while comments on
index columns might have some value, it's not worth the risk of compatibility
problems due to possible changes in the algorithm for assigning names to
index columns. Per discussion.

In consequence, remove now-dead code for copying such comments in CREATE TABLE
LIKE.

Modified Files:
--------------
pgsql/src/backend/commands:
comment.c (r1.110 -> r1.111)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/comment.c?r1=1.110&r2=1.111)
pgsql/src/backend/parser:
parse_utilcmd.c (r2.33 -> r2.34)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_utilcmd.c?r1=2.33&r2=2.34)
pgsql/src/test/regress/expected:
inherit.out (r1.29 -> r1.30)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/inherit.out?r1=1.29&r2=1.30)
pgsql/src/test/regress/sql:
inherit.sql (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/inherit.sql?r1=1.14&r2=1.15)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-12-23 02:35:25 pgsql: Adjust naming of indexes and their columns per recent discussion.
Previous Message Peter Eisentraut 2009-12-22 23:27:41 pgsql: In CREATE SEQUENCE dump, put MINVALUE before MAXVALUE so it reads