Re: enable-thread-safety defaults?

Peter Eisentraut wrote:
> On tis, 2009-12-01 at 18:03 -0500, Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > > > 2009/12/1 Bruce Momjian <bruce(at)momjian(dot)us>:
> > > >> What are we going to do for build farm members who don't support
> > > >> threading? Is someone going to manually update their configure flags?
> > >
> > > > Yeah, I think so.
> > >
> > > > Unless there's a whole lot of them, in which case we revert the patch.
> > >
> > > It would seem like we ought to try the one-liner patch Magnus proposed
> > > (ie flip the default) and see what the effects are, before we go with
> > > the much larger patch Bruce wrote.
> >
> > OK, done --- let the breakage begin. (I will be monitoring the build
> > farm and will work with Andrew Dunstan on any issues.)
>
> You have removed all the configure code that defined
> ENABLE_THREAD_SAFETY, but there is still lots and lots of code that
> checks for #ifdef ENABLE_THREAD_SAFETY. So this is is probably quite
> broken at the moment.

Yep, you have identified the bug, and I have applied the proper patch,
thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +