From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | "pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fwd: [Bug 484145] [NEW] Keyboard shortcuts for closing window / application inconsistent with GNOME |
Date: | 2009-12-03 09:26:20 |
Message-ID: | 200912031026.21007.guillaume@lelarge.info |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Le jeudi 3 décembre 2009 à 10:19:42, Dave Page a écrit :
> On Thu, Dec 3, 2009 at 8:57 AM, Guillaume Lelarge
>
> <guillaume(at)lelarge(dot)info> wrote:
> > Le jeudi 3 décembre 2009 à 09:34:43, Dave Page a écrit :
> >> On Wed, Dec 2, 2009 at 10:42 PM, Guillaume Lelarge
> >>
> >> <guillaume(at)lelarge(dot)info> wrote:
> >> > Hmmm, no comments on this patch? usually, I would commit it right away
> >> > :) but as there were objections on the issue, I don't know what I
> >> > should do.
> >>
> >> If it works as you describe, then of course, no objections from me.
> >
> > I've commited it in trunk. I'm not sure this is something I want to/can
> > commit to the 1.10 branch. Any opinion on this?
>
> Borderline case. As it doesn't stop the existing keys from working, I
> think it's OK.
>
OK, I'm doing it this morning (waiting for the compile and test to finish).
> BTW, I (finally) expect to cut 1.10.1 today - probably later this morning.
>
That's a great news.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | svn | 2009-12-03 09:43:11 | SVN Commit by guillaume: r8104 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/frm |
Previous Message | Dave Page | 2009-12-03 09:19:42 | Re: Fwd: [Bug 484145] [NEW] Keyboard shortcuts for closing window / application inconsistent with GNOME |