Re: Fwd: [Bug 484145] [NEW] Keyboard shortcuts for closing window / application inconsistent with GNOME

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Cc: Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: Fwd: [Bug 484145] [NEW] Keyboard shortcuts for closing window / application inconsistent with GNOME
Date: 2009-12-02 22:42:20
Message-ID: 200912022342.20291.guillaume@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Le jeudi 19 novembre 2009 à 21:57:43, Guillaume Lelarge a écrit :
> Le jeudi 19 novembre 2009 à 08:19:06, Guillaume Lelarge a écrit :
> > Le jeudi 19 novembre 2009 à 08:12:29, Dave Page a écrit :
> > > On Thu, Nov 19, 2009 at 4:05 PM, Guillaume Lelarge
> > >
> > > <guillaume(at)lelarge(dot)info> wrote:
> > > > Hi,
> > > >
> > > > This is a bug report from Ubuntu's Launchpad. I think they are right,
> > > > and wonder why we use the Alt-F4 shortcut. Probably something that
> > > > was done in the first releases of pgAdmin?
> > >
> > > Probably - but also we've tried to standardise the keys in pgAdmin
> > > across platforms, to help users that run different OSs.
> >
> > AFAICT, Ctrl-Q and Ctrl-W are far more standardize on the different OSs
> > than Alt-F4. I have a bad memory, but I really don't remember using
> > Alt-F4 on Mac OS X.
>
> Here is a patch that fixes this. Try it, you'll be able to use Alt-F4 or
> Ctrl- Q on the main window and Alt-F4 or Ctrl-W on the other ones
> (querytool for example). Only Ctrl-Q and Ctrl-W are displayed in the Quit
> menu item.
>
> Other comments?
>

Hmmm, no comments on this patch? usually, I would commit it right away :) but
as there were objections on the issue, I don't know what I should do.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2009-12-03 08:34:43 Re: Fwd: [Bug 484145] [NEW] Keyboard shortcuts for closing window / application inconsistent with GNOME
Previous Message Guillaume Lelarge 2009-12-02 22:11:29 Re: Next patch for 8.5 support: WHEN clause in CREATE TRIGGER