From: | David Fetter <david(at)fetter(dot)org> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, PGDG <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: plpgsql EXECUTE will not set FOUND |
Date: | 2009-11-10 06:58:27 |
Message-ID: | 20091110065827.GD7073@fetter.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Nov 09, 2009 at 09:01:14PM -0500, Bruce Momjian wrote:
>
> I have applied the attached patch to document that FOUND is not affected
> by EXECUTE, while GET DIAGNOSTICS is.
One minor nit here:
> Index: doc/src/sgml/plpgsql.sgml
> ===================================================================
> RCS file: /cvsroot/pgsql/doc/src/sgml/plpgsql.sgml,v
> retrieving revision 1.143
> diff -c -c -r1.143 plpgsql.sgml
> *** doc/src/sgml/plpgsql.sgml 29 Sep 2009 20:05:29 -0000 1.143
> --- doc/src/sgml/plpgsql.sgml 10 Nov 2009 01:55:33 -0000
> ***************
> *** 1366,1372 ****
>
> <literal>FOUND</literal> is a local variable within each
> <application>PL/pgSQL</application> function; any changes to it
> ! affect only the current function.
> </para>
>
> </sect2>
> --- 1366,1374 ----
>
> <literal>FOUND</literal> is a local variable within each
> <application>PL/pgSQL</application> function; any changes to it
> ! affect only the current function. <literal>FOUND</literal> is not
> ! affected by <literal>EXECUTE</literal>, while <command>GET
> ! DIAGNOSTICS</command> is effected.
The passive form of this phrase would be "is affected," instead of "is
effected," or (my preference) change to an active construction like:
<literal>EXECUTE</literal> changes the output of <command>GET
DIAGNOSTICS</command>, but does not change the state of
<literal>FOUND</literal>.
Cheers,
David (Strunk and White ftw! ;)
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
From | Date | Subject | |
---|---|---|---|
Next Message | Itagaki Takahiro | 2009-11-10 07:22:33 | Issues in partitioning - constraint dependency |
Previous Message | Tom Lane | 2009-11-10 03:37:02 | Re: drop tablespace error: invalid argument |