From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: WIP: pushing parser hooks through SPI and plancache |
Date: | 2009-11-04 17:11:22 |
Message-ID: | 20091104171122.GD3531@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> It turns out that this typedef is needed in two relatively low-level
> .h files: nodes/params.h and utils/plancache.h. My original idea had
> been to define the hook typedef in parser/parse_node.h where struct
> ParseState is defined. But that would have required pulling a boatload
> of parser headers into these two .h files, which seems like a bad idea
> (it might even lead to circular includes). For the moment I've worked
> around this by putting the typedef into nodes/params.h itself, but I
> can't say I find that a pleasing solution. Has anyone got a better
> idea? Should we make a parser/something header that just provides that
> typedef?
Hmm ... if you create the new include file, is that going to avoid
having to include params.h in plancache.h? If not, I don't think
there's much point in having a new file (other than the typedef just not
fitting in params.h).
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Jaime Casanova | 2009-11-04 17:28:02 | Re: new version of PQconnectdb was:(Re: [HACKERS] Determining client_encoding from client locale) |
Previous Message | Chris Browne | 2009-11-04 17:08:59 | Re: Proposal - temporal contrib module |