Re: syslog_line_prefix

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: syslog_line_prefix
Date: 2009-09-25 16:13:37
Message-ID: 20090925161337.GO3914@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas escribió:

> On the other hand, I don't think this is the right way to do it. The
> patch proposes the following mapping of logging destinations to GUCs:
>
> stderr -> log_line_prefix (same as now)
> csvlog -> not applicable (same as now)
> syslog -> syslog_line_prefix
> eventlog -> syslog_line_prefix
>
> That's not exactly mnemonic; I think we'd want
> {stderr,syslog,eventlog}_log_line_prefix if anything.

So let's have a (ugh) fourth GUC that keeps the current name
log_line_prefix and is the default value for all the other vars.
So today's config would continue to work identically, and people wanting
more configurable behavior could get it by simply setting one or more of
the new vars.

The only problem is what would we do when we implement Magnus' idea.
Are we close to that?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-09-25 16:27:58 Re: recovery is stuck when children are not processing SIGQUIT from previous crash
Previous Message Dave Page 2009-09-25 16:05:34 Re: Docs build error in alpha1