| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | jeff(dot)janes(at)gmail(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgbench hard coded constants |
| Date: | 2009-09-09 03:44:34 |
| Message-ID: | 20090909.124434.112620462.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> pgbench has #defines for number of branches, tellers, and accounts. There
> are used to populate the tables with -i, but when running actual benchmark
> it has values separately hard-coded in the query metacommands. This patch
> makes the metacommands obtain their values from the relevant #defines.
Good catch! Long standing bug...
> It has been tested to the extent that after changing the #define naccounts
> downward, without the patch, after running both -i once and the benchmark
> itself once leads to inconsistent results (select sum(abalance) from
> pgbench_accounts does not equal sum(delta) from pgbench_history), while
> with the patch they are equal.
Looks good. If there's no objection, I will commit into CVS HEAD.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2009-09-09 05:55:38 | Re: Disable and enable of table and column constraints |
| Previous Message | Tatsuo Ishii | 2009-09-09 03:37:18 | Re: ecpg build failed on CVS HEAD |