pgsql: Avoid calling kill() in a postmaster signal handler.

From: alvherre(at)postgresql(dot)org (Alvaro Herrera)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid calling kill() in a postmaster signal handler.
Date: 2009-08-24 17:23:29
Message-ID: 20090824172329.2065375331E@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Avoid calling kill() in a postmaster signal handler.

This causes problems when the system load is high, per report from Zdenek
Kotala in <1250860954(dot)1239(dot)114(dot)camel(at)localhost>; instead of calling kill
directly, have the signal handler set a flag which is checked in ServerLoop.
This way, the handler can return before being called again by a subsequent
signal sent from the autovacuum launcher. Also, increase the sleep in the
launcher in this failure path to 1 second.

Backpatch to 8.3, which is when the signalling between autovacuum
launcher/postmaster was introduced.

Also, add a couple of ReleasePostmasterChildSlot calls in error paths; this
part backpatched to 8.4 which is when the child slot stuff was introduced.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
pgsql/src/backend/postmaster:
autovacuum.c (r1.71.2.9 -> r1.71.2.10)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/autovacuum.c?r1=1.71.2.9&r2=1.71.2.10)
postmaster.c (r1.551.2.3 -> r1.551.2.4)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/postmaster.c?r1=1.551.2.3&r2=1.551.2.4)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-08-24 18:09:37 pgsql: Small correction to previous patch: we shouldn't
Previous Message Alvaro Herrera 2009-08-24 17:23:17 pgsql: Avoid calling kill() in a postmaster signal handler.