| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Roger Leigh <rleigh(at)codelibre(dot)net> |
| Cc: | Roger Leigh <rleigh(at)debian(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH 5/6] psql: print_aligned_text uses table formatting |
| Date: | 2009-08-23 22:29:12 |
| Message-ID: | 20090823222912.GB5287@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Roger Leigh wrote:
> On Sun, Aug 23, 2009 at 11:47:02AM -0400, Alvaro Herrera wrote:
> > Wouldn't it be better to do a single fprintf call here instead of
> > fputc + fputs?
>
> It's certainly possible to change it; the above might be slightly more
> efficient than a call to fprintf since you skip parsing the format
> string, but otherwise I have no real preference for one over the
> other.
There are already other fprintf calls in the same function -- I wouldn't
worry too much about some hypothetical performance gain. Let's keep
things simple and readable.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2009-08-23 22:33:49 | Re: Unicode UTF-8 table formatting for psql text output |
| Previous Message | Grzegorz Jaskiewicz | 2009-08-23 22:16:59 | Re: clang's static checker report. |