Re: fillfactor hides autovacuum parameters in 8.4.0

From: Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: fillfactor hides autovacuum parameters in 8.4.0
Date: 2009-08-20 03:18:22
Message-ID: 20090820121234.999B.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers


Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:

> > We should remember whether a field was specified or not independntly.
> I'm not sure what you are suggesting ...?

Please imagine that:

=# SET autovacuum_vacuum_scale_factor = 0.05;
=# ALTER TABLE tbl SET (autovacuum_vacuum_threshold = 10);

AutoVacOpts.vacuum_threshold should be 10 (comes from reloptions),
but AutoVacOpts.vacuum_scale_factor should be <DEFAULT> (comes from GUC).

If we use boolean flags, we need booleans for each fields in AutoVacOpts.
(vacuum_threshold_is_default, vacuum_scale_factor_is_default, ...)

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2009-08-20 03:27:15 Re: fillfactor hides autovacuum parameters in 8.4.0
Previous Message Alvaro Herrera 2009-08-20 03:10:09 Re: fillfactor hides autovacuum parameters in 8.4.0

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-08-20 03:19:42 Re: hot standby - merged up to CVS HEAD
Previous Message Alvaro Herrera 2009-08-20 03:10:09 Re: fillfactor hides autovacuum parameters in 8.4.0