schemapg.h

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: schemapg.h
Date: 2009-08-12 22:16:28
Message-ID: 20090812221628.GN5721@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I think having schemapg.h be autogenerated is a good idea, so I stripped
that from Robert Haas' patch. Here's the result. This should be
relatively uncontroversial since, well, the controversial stuff has been
stripped. The one problem is that it introduces more complex code than
it removes dull declarations.

Ideally this would serve as a basis upon which the rest of the generated
stuff is built. I think it would be good to have a module that contains
common code. In particular we could move process_input_file() to it,
and pass function refs for each subblock. That way each program could
be relatively short, and the regexes that parse the files would all be
in a single place.

Thoughts?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment Content-Type Size
schemapg_h.patch text/x-diff 30.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-08-12 22:20:39 Re: COPY speedup
Previous Message Tom Lane 2009-08-12 21:57:34 Re: Why is vacuum_freeze_min_age 100m?