Re: pg_dump Add dumping of comments on index columns

Tom Lane wrote:
> Brendan Jurd <direvus(at)gmail(dot)com> writes:
> > I've also done an initial review of the patch. Everything looks sane
> > and the patch works as advertised. I made a couple of minor tweaks
> > for code-style and comment consistency, and my version 3 is attached.
>
> > I'm marking this patch Ready for Committer.
>
> Applied with minor revisions --- mostly, it leaked memory in the case
> of no comments, and the query wasn't very schema-safe.

Just to verify, this patch was about comments on composite columns, not
about dumping comments on index columns (as the subject states), right?
We do have a TODO for index column comments:

Forbid COMMENT on columns of an index

Postgres currently allows comments to be placed on the columns of an
index, but pg_dump doesn't handle them and the column names themselves
are implementation-dependent.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +