Re: Status report: getting plpgsql to use the core lexer

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Status report: getting plpgsql to use the core lexer
Date: 2009-07-15 23:29:39
Message-ID: 20090715232939.GQ4551@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

> Another pretty serious issue is that the current plpgsql lexer treats
> various sorts of qualified names as single tokens. I had thought this
> could be worked around in the interface layer by doing more lookahead.
> You can do that, and it mostly works, but it's mighty tedious. The big
> problem is that "yytext" gets out of step --- it will point at the last
> token the core lexer has processed, and there's no good way to back it up
> after lookahead. I spent a fair amount of time trying to work around that
> by eliminating uses of "yytext" in plpgsql, and mostly succeeded, but
> there are still some left. (Some of the remaining regression failures are
> error messages that point at the wrong token because they rely on yytext.)

Just wondering if there are additional regressions not detected due to
pg_regress using the ignore-whitespace option to diff.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-07-15 23:40:58 Re: Status report: getting plpgsql to use the core lexer
Previous Message Tom Lane 2009-07-15 23:15:37 Re: initdb auth method option and "ident sameuser"