Re: Changed error message for blocks by prepared transactions

From: Andreas 'ads' Scherbaum <adsmail(at)wars-nicht(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Changed error message for blocks by prepared transactions
Date: 2009-06-23 09:16:38
Message-ID: 20090623111638.02f75579@iridium.wars-nicht.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 22 Jun 2009 19:24:28 -0400 Tom Lane wrote:

> "Andreas 'ads' Scherbaum" <adsmail(at)wars-nicht(dot)de> writes:
> > the small attached patch changes the error message for a blocked
> > database in case there are prepared transactions.
>
> Isn't this duplicative of the errdetail_busy_db code? And anyway
> I do not see a reason not to consider prepared transactions as
> "other users".

Because you know the details.
Most other users check pg_stat_activity just to find out there is no
other user connected. A prepared transaction is not a connected user,
so the error message is still misleading.

You are right with the errdetail_busy_db(), but that's only true for
8.4, not for earlier versions. In addition that's only true if you
haven't supressed the hints like some scripts do (-q as example).

Bye

--
Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project

PGDay.eu 2009 in Paris, Nov. 6/7, http://www.pgday.eu/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-06-23 13:25:43 8.4RC2 is available
Previous Message Fujii Masao 2009-06-23 06:41:22 Re: Synch Rep: communication between backends and walsender