Re: Should mdxxx functions(e.g. mdread, mdwrite, mdsync etc) PANIC instead of ERROR when I/O failed?

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Jacky Leng <lengjianquan(at)163(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Should mdxxx functions(e.g. mdread, mdwrite, mdsync etc) PANIC instead of ERROR when I/O failed?
Date: 2009-06-15 11:26:47
Message-ID: 20090615112647.GA22208@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 15, 2009 at 04:41:42PM +0800, Jacky Leng wrote:
> My question is: should not mdxxx functions(e.g. mdread, mdwrite, mdsync)
> just report PANIC instead of ERROR when I/O failed? IMO, since the data has
> already corrupted, reporting ERROR will just leave us a very curious scene
> later -- which does more harm that benefit.

I think the reasoning is that if those functions reported a PANIC the
chance you could recover your data is zero, because you need the
database system to read the other (good) data.

With an ERROR you can investigate the problem and save what can de
saved...

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-06-15 12:01:13 Re: machine-readable explain output
Previous Message Jacky Leng 2009-06-15 08:41:42 Should mdxxx functions(e.g. mdread, mdwrite, mdsync etc) PANIC instead of ERROR when I/O failed?