Re: pg_migrator issue with contrib

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Brad Nicholson <bnichols(at)ca(dot)afilias(dot)info>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_migrator issue with contrib
Date: 2009-06-08 15:15:16
Message-ID: 200906081515.n58FFG304925@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander wrote:
> >>> Could pg_migrator detect usage of "objects" oids (data types in
> >>> relation, index opclass, ...) that are unknown to be in the standard
> >>> -core + contrib distribution, and quit trying to upgrade the cluster in
> >>> this case, telling the user his database is not supported?
> >
> >> +1 on this.
> >
> >> Or at least, have it exit and say "if you know that these things are
> >> reasonably safe, run pg_migrator again with --force" or something like that.
> >
> > I don't think that anything in that line is going to be helpful.
> > What it will lead to is people mindlessly using --force (cf our
> > bad experiences with -i for pg_dump). If you can't give a *useful*
> > ie trustworthy warning/error, issuing a useless one is not a good
> > substitute.
>
> Well, in that case, error out would be a better option than doing it and
> probably fail later. And have a --force option available, but don't
> suggest it.

Uh, what doesn't error out now in pg_migrator?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2009-06-08 15:15:19 Re: pg_migrator issue with contrib
Previous Message Bruce Momjian 2009-06-08 15:14:29 Re: pg_migrator issue with contrib