| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com> |
| Subject: | Re: [PATCH] Compiler warning cleanup |
| Date: | 2009-05-23 21:40:17 |
| Message-ID: | 200905240040.18078.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Saturday 23 May 2009 00:04:26 Zdenek Kotala wrote:
> Attached patch fixes following sun studio compiler warning:
>
> "tsquery_op.c", line 193: warning: syntax error: empty declaration
[snip]
> --- 190,201 ----
> PG_RETURN_BOOL( CONDITION ); \
> }
>
> ! CMPFUNC(tsquery_lt, res < 0)
> ! CMPFUNC(tsquery_le, res <= 0)
> ! CMPFUNC(tsquery_eq, res == 0)
> ! CMPFUNC(tsquery_ge, res >= 0)
> ! CMPFUNC(tsquery_gt, res > 0)
> ! CMPFUNC(tsquery_ne, res != 0)
>
> TSQuerySign
> makeTSQuerySign(TSQuery a)
I think this is not the best way to do it, because it will confuse pgindent
and editors and such. The DATA() macros in include/catalog have this solved;
see include/catalog/genbki.sh.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2009-05-23 21:57:40 | Re: information_schema.columns changes needed for OLEDB |
| Previous Message | Zdenek Kotala | 2009-05-23 21:14:49 | Re: psql is broken in 8.4 |