| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Some 8.4 changes needed according to pg_migrator testing |
| Date: | 2009-05-08 21:55:42 |
| Message-ID: | 200905082155.n48Ltg823846@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> No, that sounds like it should be sufficient ... but you need to check
> >> the template0 encodings match too, assuming that we make encoding and
> >> locale work the same here.
>
> > OK, are you suggesting checking the pg_database.encoding for
> > template0 for both servers because that information isn't in either
> > pg_controldatas?
>
> Right. Compare old template0 encoding against new template0 encoding,
> and old locale information from pg_controldata against new template0
> locale information. If these match then it will be safe to let
> pg_dumpall omit the corresponding CREATE DATABASE parameters.
OK, encoding check added to pg_migrator.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Khee Chin | 2009-05-08 22:13:38 | Re: Show method of index |
| Previous Message | Seth Robertson | 2009-05-08 21:52:12 | Re: [PATCH] Automatic client certificate selection support for libpq v1 |