Re: Some 8.4 changes needed according to pg_migrator testing

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Some 8.4 changes needed according to pg_migrator testing
Date: 2009-05-08 21:33:24
Message-ID: 15554.1241818404@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> No, that sounds like it should be sufficient ... but you need to check
>> the template0 encodings match too, assuming that we make encoding and
>> locale work the same here.

> OK, are you suggesting checking the pg_database.encoding for
> template0 for both servers because that information isn't in either
> pg_controldatas?

Right. Compare old template0 encoding against new template0 encoding,
and old locale information from pg_controldata against new template0
locale information. If these match then it will be safe to let
pg_dumpall omit the corresponding CREATE DATABASE parameters.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2009-05-08 21:40:56 SSL cert chains patch
Previous Message Bruce Momjian 2009-05-08 21:29:45 Re: Some 8.4 changes needed according to pg_migrator testing