Re: psql with "Function Type" in \df

From: David Fetter <david(at)fetter(dot)org>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql with "Function Type" in \df
Date: 2009-04-27 16:51:46
Message-ID: 20090427165145.GJ1539@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 27, 2009 at 10:39:33AM -0400, Alvaro Herrera wrote:
> David Fetter wrote:
> > On Fri, Apr 17, 2009 at 04:42:31PM -0400, Alvaro Herrera wrote:
>
> > > It also seems like we're missing tab completion support for this.
> >
> > Oops. Working on that now.
>
> Any luck with this?

I have a handle on the problem, which is that the tab completion code
assumes, wrongly, that it only needs to deal with fixed strings. It's
actually been false for some time in the \div case, for example. The
S option has shattered the fixed-string assumption.

I'm proposing to refactor the backslash handling code so all of it is
in one spot with differences in the target list and WHERE clauses
depending on whether it's tab completion, S, +, what I'm thinking of
as second-level options--the [ivt]* in \d[ivt]* and the [antw]* in
\df[antw]*[S+]--and patterns.

Does this sound reasonable?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-04-27 17:11:44 Re: psql with "Function Type" in \df
Previous Message Sam Halliday 2009-04-27 15:37:25 Re: RFE: Transparent encryption on all fields